Page MenuHomePhabricator
Differential D12320

Fix "To: Unknown Object" on outbound Maniphest mail with no owner
ClosedPublic
Actions

Authored by epriestley on Apr 8 2015, 12:16 PM.
Tags
None
Referenced Files
F13106752: D12320.diff
Sat, Apr 27, 8:59 PM
Unknown Object (File)
Sun, Mar 31, 10:42 PM
Unknown Object (File)
Sun, Mar 31, 12:15 AM
Unknown Object (File)
Mar 2 2024, 3:47 AM
Unknown Object (File)
Feb 13 2024, 11:40 PM
Unknown Object (File)
Feb 13 2024, 11:40 PM
Unknown Object (File)
Feb 13 2024, 11:34 PM
Unknown Object (File)
Feb 13 2024, 10:52 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T7778: "Unknown Object (????)" in outbound email
Commits
Restricted Diffusion Commit
rP13c0c3b850ea: Fix "To: Unknown Object" on outbound Maniphest mail with no owner
Summary

Fixes T7778. This was likely caused by removing an array_filter() somewhere in the course of T7731, but I'd rather have the code be more correct.

Test Plan

Sent mail on a task with no owner.

  • Before patch: unknown recipient.
  • After patch: expected recipients.

Diff Detail

Repository
rP Phabricator
Branch
mailto
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5191
Build 5209: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29601.Apr 8 2015, 12:16 PM
epriestley retitled this revision from to Fix "To: Unknown Object" on outbound Maniphest mail with no owner.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T7778: "Unknown Object (????)" in outbound email.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 8 2015, 12:16 PM
joshuaspence accepted this revision.Apr 8 2015, 12:20 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 12:20 PM
Closed by commit rP13c0c3b850ea: Fix "To: Unknown Object" on outbound Maniphest mail with no owner (authored by epriestley, committed by epriestley). · Explain WhyApr 8 2015, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
editor/
12 lines

Diff 29601

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
Phabricator · Built by Phacility