Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 5:29 AM
Unknown Object (File)
Fri, Jan 24, 2:13 AM
Unknown Object (File)
Fri, Jan 24, 2:13 AM
Unknown Object (File)
Fri, Jan 24, 2:13 AM
Unknown Object (File)
Tue, Jan 21, 12:54 PM
Unknown Object (File)
Fri, Jan 17, 9:03 PM
Unknown Object (File)
Mon, Jan 13, 6:06 PM
Unknown Object (File)
Fri, Jan 10, 4:58 PM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5153
Build 5171: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.