Page MenuHomePhabricator

Don't pass data to `jshint` via STDIN
ClosedPublic

Authored by joshuaspence on Apr 6 2015, 12:36 PM.
Tags
None
Referenced Files
F15440891: D12298.id29528.diff
Wed, Mar 26, 3:16 PM
F15440426: D12298.id.diff
Wed, Mar 26, 12:49 PM
F15437517: D12298.diff
Tue, Mar 25, 8:01 PM
F15427767: D12298.id29558.diff
Sun, Mar 23, 3:59 PM
F15414335: D12298.diff
Thu, Mar 20, 12:10 AM
F15410643: D12298.diff
Wed, Mar 19, 8:00 AM
F15396856: D12298.id29528.diff
Sun, Mar 16, 4:39 PM
F15396626: D12298.diff
Sun, Mar 16, 3:28 PM
Subscribers

Details

Summary

Fixes T7464. JSHint is unable to exclude files from linting (via the jshintignore file) if the data is piped through STDIN. An alternative would be to pass $options[] = '--filename='.$this->getActivePath(), but $this->getActivePath() is not set when the command arguments are constructed.

Test Plan

Created a file and linted it with ArcanistJSHintLinter. Was able to exclude the file from linting with a jshintignore file.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Don't pass data to `jshint` via STDIN.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

This approach is consistent with my intent via T7674.

This revision is now accepted and ready to land.Apr 6 2015, 12:45 PM
This revision was automatically updated to reflect the committed changes.