Paths

Table of Contentst

Differential D12056

Collapse Dashboards to single column when durable present and narrow
ClosedPublic
Actions

Authored by chad on Mar 12 2015, 8:54 PM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7531: Polish for Conpherence Durable Column

Commits

Restricted Diffusion Commit
rP41875ce7b487: Collapse Dashboards to single column when durable present and narrow

Summary

Currently we punch down Dashboard columns on smaller displays. This adds another set of rules for if durable-column is present.

Test Plan

Test breakpoints at 1300 and 1000 pixel wide.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29020.Mar 12 2015, 8:54 PM

chad retitled this revision from to Collapse Dashboards to single column when durable present and narrow.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 12 2015, 8:54 PM

chad added a task: T7531: Polish for Conpherence Durable Column.Mar 12 2015, 9:54 PM

alternatively we could js detect 'narrow-desktop' in addition to 'phone' and 'tablet' at 1000px.

I plan to make the breakpoint consider whether the column is present (T7062) but that won't work with stuff that's issuing raw @media queries.

This revision is now accepted and ready to land.Mar 14 2015, 3:27 PM

ah D10956. I wonder if you're really on a tablet, you're likely landscape anyways.

Closed by commit rP41875ce7b487: Collapse Dashboards to single column when durable present and narrow (authored by chad, committed by chad). · Explain WhyMar 14 2015, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

multi-column.css

38 lines

Diff 29060

View Options

resources/celerity/map.php