Page MenuHomePhabricator
Differential D12056

Collapse Dashboards to single column when durable present and narrow
ClosedPublic
Actions

Authored by chad on Mar 12 2015, 8:54 PM.
Tags
None
Referenced Files
F13191908: D12056.diff
Sun, May 12, 2:19 AM
F13179671: D12056.diff
Wed, May 8, 9:21 PM
Unknown Object (File)
Sat, May 4, 6:56 PM
Unknown Object (File)
Wed, May 1, 12:24 AM
Unknown Object (File)
Tue, Apr 30, 4:53 PM
Unknown Object (File)
Tue, Apr 30, 4:53 PM
Unknown Object (File)
Tue, Apr 30, 4:53 PM
Unknown Object (File)
Mon, Apr 29, 2:22 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7531: Polish for Conpherence Durable Column
Commits
Restricted Diffusion Commit
rP41875ce7b487: Collapse Dashboards to single column when durable present and narrow
Summary

Currently we punch down Dashboard columns on smaller displays. This adds another set of rules for if durable-column is present.

Test Plan

Test breakpoints at 1300 and 1000 pixel wide.

Diff Detail

Repository
rP Phabricator
Branch
media-css
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4861
Build 4879: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29020.Mar 12 2015, 8:54 PM
chad retitled this revision from to Collapse Dashboards to single column when durable present and narrow.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 12 2015, 8:54 PM
chad added a task: T7531: Polish for Conpherence Durable Column.Mar 12 2015, 9:54 PM
chad added a comment.Mar 14 2015, 2:44 PM

alternatively we could js detect 'narrow-desktop' in addition to 'phone' and 'tablet' at 1000px.

epriestley accepted this revision.Mar 14 2015, 3:27 PM
epriestley edited edge metadata.

I plan to make the breakpoint consider whether the column is present (T7062) but that won't work with stuff that's issuing raw @media queries.

This revision is now accepted and ready to land.Mar 14 2015, 3:27 PM
chad added a comment.Mar 14 2015, 3:29 PM

ah D10956. I wonder if you're really on a tablet, you're likely landscape anyways.

Closed by commit rP41875ce7b487: Collapse Dashboards to single column when durable present and narrow (authored by chad, committed by chad). · Explain WhyMar 14 2015, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
aphront/
38 lines

Diff 29020

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/multi-column.css

Loading...
Phabricator · Built by Phacility