Page MenuHomePhabricator

Have home dashboards go to single column on narrow desktops
ClosedPublic

Authored by chad on Dec 10 2014, 4:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 6:21 PM
Unknown Object (File)
Wed, Mar 27, 6:18 PM
Unknown Object (File)
Wed, Mar 27, 6:08 PM
Unknown Object (File)
Wed, Mar 27, 2:48 PM
Unknown Object (File)
Wed, Mar 27, 1:58 PM
Unknown Object (File)
Wed, Mar 27, 1:57 PM
Unknown Object (File)
Sun, Mar 24, 11:55 PM
Unknown Object (File)
Sun, Mar 17, 8:31 PM
Subscribers

Details

Summary

Ref T6723. Because of the sidenav, some dashboard layouts may perform poorly on more narrow desktop displays. This provides an additional media query and CSS rules.

Test Plan

Move viewport to 1001 px, see desktop, move to 999 pixels, see tablet-like display.

Screen_Shot_2014-12-10_at_8.35.49_AM.png (782×1 px, 243 KB)

Screen_Shot_2014-12-10_at_8.36.04_AM.png (864×1 px, 289 KB)

Screen_Shot_2014-12-10_at_8.36.15_AM.png (890×2 px, 385 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Have home dashboards go to single column on narrow desktops.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2014, 4:42 PM
chad edited edge metadata.
  • Add a 2-up test

@epriestley I presume if we need this more, maybe a device-desktop-narrow rule?

We could also move the "tablet" breakpoint to 1000px instead of 768px.

This revision was automatically updated to reflect the committed changes.

That might not be a bad idea. I can play with how it feels locally for a bit. The main thing is the header changes, which is likely not important to alter anyways at 768.

as in, make the header collapse at phone only