Page MenuHomePhabricator
Differential D12072

Prepare file responses for streaming chunks
ClosedPublic
Actions

Authored by epriestley on Mar 13 2015, 8:57 PM.
Tags
None
Referenced Files
F20677975: D12072.diff
Sun, Jun 21, 10:21 PM
Unknown Object (File)
Apr 15 2026, 6:48 PM
Unknown Object (File)
Apr 15 2026, 1:28 PM
Unknown Object (File)
Apr 15 2026, 1:27 PM
Unknown Object (File)
Apr 15 2026, 1:27 PM
Unknown Object (File)
Apr 7 2026, 5:44 PM
Unknown Object (File)
Apr 2 2026, 10:44 PM
Unknown Object (File)
Mar 23 2026, 7:47 PM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
btrahan
Maniphest Tasks
T7149: Allow users to import data into a new Phacility instance
Commits
Restricted Diffusion Commit
rP81d88985a027: Prepare file responses for streaming chunks
Summary

Ref T7149. This still buffers the whole file, but is reaaaaal close to not doing that.

Allow Responses to be streamed, and rewrite the range stuff in the FileResponse so it does not rely on having the entire content available.

Test Plan
  • Artificially slowed down downloads, suspended/resumed them (works in chrome, not so much in Safari/Firefox?)
  • Played sounds in Safari/Chrome.
  • Viewed a bunch of pages and files in every browser.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29047.Mar 13 2015, 8:57 PM
epriestley retitled this revision from to Prepare file responses for streaming chunks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7149: Allow users to import data into a new Phacility instance.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 13 2015, 8:57 PM
joshuaspence added a subscriber: joshuaspence.Mar 13 2015, 10:29 PM
btrahan accepted this revision.Mar 13 2015, 10:35 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 10:35 PM
Closed by commit rP81d88985a027: Prepare file responses for streaming chunks (authored by epriestley, committed by epriestley). · Explain WhyMar 14 2015, 3:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
63 lines
20 lines
sink/
19 lines
4 lines
9 lines
applications/
files/
controller/
24 lines
query/
8 lines

Diff 29055

View Options

src/aphront/response/AphrontFileResponse.php

Loading...
View Options

src/aphront/response/AphrontResponse.php

Loading...
View Options

src/aphront/sink/AphrontHTTPSink.php

Loading...
View Options

src/aphront/sink/AphrontIsolatedHTTPSink.php

Loading...
View Options

src/aphront/sink/AphrontPHPHTTPSink.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
Phabricator · Built by Phacility