Page MenuHomePhabricator

Prepare file responses for streaming chunks
ClosedPublic

Authored by epriestley on Mar 13 2015, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 10:59 PM
Unknown Object (File)
Tue, Dec 24, 9:49 PM
Unknown Object (File)
Sun, Dec 22, 3:42 AM
Unknown Object (File)
Fri, Dec 20, 5:14 AM
Unknown Object (File)
Mon, Dec 9, 9:13 AM
Unknown Object (File)
Sun, Dec 8, 3:34 PM
Unknown Object (File)
Nov 27 2024, 4:17 AM
Unknown Object (File)
Nov 19 2024, 9:51 AM

Details

Summary

Ref T7149. This still buffers the whole file, but is reaaaaal close to not doing that.

Allow Responses to be streamed, and rewrite the range stuff in the FileResponse so it does not rely on having the entire content available.

Test Plan
  • Artificially slowed down downloads, suspended/resumed them (works in chrome, not so much in Safari/Firefox?)
  • Played sounds in Safari/Chrome.
  • Viewed a bunch of pages and files in every browser.

Diff Detail

Repository
rP Phabricator
Branch
chunk7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4878
Build 4896: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Prepare file responses for streaming chunks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 10:35 PM
This revision was automatically updated to reflect the committed changes.