Page MenuHomePhabricator

Maniphest - fix blocking / blocked task queries
ClosedPublic

Authored by btrahan on Mar 3 2015, 11:14 PM.
Tags
None
Referenced Files
F13189457: D11962.diff
Sat, May 11, 6:00 AM
F13186982: D11962.diff
Sat, May 11, 4:15 AM
Unknown Object (File)
Tue, May 7, 7:20 AM
Unknown Object (File)
Fri, May 3, 5:54 AM
Unknown Object (File)
Thu, Apr 25, 12:59 AM
Unknown Object (File)
Apr 7 2024, 7:57 AM
Unknown Object (File)
Feb 21 2024, 7:27 AM
Unknown Object (File)
Feb 21 2024, 7:27 AM
Subscribers

Details

Summary

Fixes T7392. I kind of stink at SQL so my approach here was to "start over" conceptually and this way makes the most sense to me - we basically do one join on the dependency table and then a second join back from the dependency table to the main task table. In the where clause we filter the resulting rows, first checking the data from dependency join for existence as appropros and then checking the second join for main task table for the proper "open" task values.

Test Plan

made a task X be blocked by task Y. closed task y. search for "not blocked" tasks and saw task X.

Diff Detail

Repository
rP Phabricator
Branch
T7392
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4740
Build 4754: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Maniphest - fix blocking / blocked task queries.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

I like this, it seems more clear to me too.

This revision is now accepted and ready to land.Mar 3 2015, 11:19 PM
This revision was automatically updated to reflect the committed changes.