Page MenuHomePhabricator
Differential D11552

Only allow `arc branch` to be used under `git`
ClosedPublic
Actions

Authored by joshuaspence on Jan 29 2015, 11:19 AM.
Tags
None
Referenced Files
F15507026: D11552.id27806.diff
Tue, Apr 15, 3:49 PM
F15505859: D11552.diff
Tue, Apr 15, 6:27 AM
F15504723: D11552.id28044.diff
Mon, Apr 14, 7:59 PM
F15494788: D11552.id27975.diff
Sun, Apr 13, 1:38 AM
F15487029: D11552.id28052.diff
Thu, Apr 10, 10:41 AM
F15485072: D11552.id28044.diff
Wed, Apr 9, 9:35 PM
F15483258: D11552.id.diff
Wed, Apr 9, 11:08 AM
F15479364: D11552.diff
Tue, Apr 8, 6:38 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC77eb24b13afb: Only allow `arc branch` to be used under `git`
Summary

Explicitly declare that the arc branch command is only supported under git.

Test Plan

N/A

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4290
Build 4303: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27806.Jan 29 2015, 11:19 AM
joshuaspence retitled this revision from to Only allow `arc branch` to be used under `git`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 29 2015, 11:19 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.EditedFeb 1 2015, 8:34 PM
joshuaspence edited edge metadata.
NOTE: This makes more sense after D11550.
joshuaspence updated this revision to Diff 27975.Feb 2 2015, 8:13 PM

Fix method visibility

epriestley requested changes to this revision.Feb 3 2015, 7:50 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/workflow/ArcanistBranchWorkflow.php
32–33

Can we delete this now?

This revision now requires changes to proceed.Feb 3 2015, 7:50 PM
joshuaspence updated this revision to Diff 28044.Feb 3 2015, 7:53 PM
joshuaspence edited edge metadata.

Remove some dead code

epriestley accepted this revision.Feb 3 2015, 7:55 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 3 2015, 7:55 PM
Closed by commit rARC77eb24b13afb: Only allow `arc branch` to be used under `git` (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 3 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
workflow/
9 lines

Diff 28044

View Options

src/workflow/ArcanistBranchWorkflow.php

Loading...
Phabricator · Built by Phacility