Paths

Table of Contentst

Differential D11552

Only allow `arc branch` to be used under `git`
ClosedPublic
Actions

Authored by joshuaspence on Jan 29 2015, 11:19 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC77eb24b13afb: Only allow `arc branch` to be used under `git`

Summary

Explicitly declare that the arc branch command is only supported under git.

Test Plan

N/A

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27806.Jan 29 2015, 11:19 AM

joshuaspence retitled this revision from to Only allow `arc branch` to be used under `git`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 29 2015, 11:19 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

NOTE: This makes more sense after D11550.

Fix method visibility

epriestley requested changes to this revision.Feb 3 2015, 7:50 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/workflow/ArcanistBranchWorkflow.php
32–33	Can we delete this now?

This revision now requires changes to proceed.Feb 3 2015, 7:50 PM

Remove some dead code

epriestley accepted this revision.Feb 3 2015, 7:55 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 7:55 PM

Closed by commit rARC77eb24b13afb: Only allow `arc branch` to be used under `git` (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 3 2015, 7:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistBranchWorkflow.php

9 lines

Diff 28052

View Options

src/workflow/ArcanistBranchWorkflow.php

Only allow `arc branch` to be used under `git`ClosedPublicActions