Differential D11639

Make the output of `xhpast --version` more compact
ClosedPublic
Actions

Authored by joshuaspence on Feb 3 2015, 7:30 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUc406bfb57fd0: Make the output of `xhpast --version` more compact

Summary

This feels a little nicer, plus is easier to parse.

Test Plan

> ./scripts/build_xhpast.sh
Build successful!
> ./src/parser/xhpast/bin/xhpast --version
5.5.8/1h

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	support/xhpast/xhpast.cpp:18	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 4269
Build 4282: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 28013.Feb 3 2015, 7:30 AM

joshuaspence retitled this revision from to Make the output of `xhpast --version` more compact.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 3 2015, 7:30 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Feb 3 2015, 1:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 3 2015, 1:12 PM

Closed by commit rPHUc406bfb57fd0: Make the output of `xhpast --version` more compact (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 3 2015, 8:01 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence mentioned this in D11335: Rebuild xhpast.exe.Feb 4 2015, 8:54 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

PhutilXHPASTBinary.php

7 lines

support/

xhpast/

xhpast.cpp

4 lines

Diff 28013

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php