Paths

Table of Contentst

Differential D11615

Remove `xhpast_parse` methods
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 10:21 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHUaa8c2233920a: Remove `xhpast_parse` methods

Summary

These methods are no longer used and have been replaced with static method calls on the PhutilXHPASTBinary class. Depends on D11612, D11613 and D11614.

Test Plan

grep

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

No Lint Coverage

Unit

Tests Passed

Build Status

Buildable 4235
Build 4248: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27950.Feb 2 2015, 10:21 AM

joshuaspence retitled this revision from to Remove `xhpast_parse` methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:21 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Good to go once callsites are gone.

This revision is now accepted and ready to land.Feb 2 2015, 1:58 PM

joshuaspence updated this object.Feb 2 2015, 8:00 PM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

joshuaspence added parent revisions: D11612: Use `PhutilXHPASTBinary` methods, D11613: Use `PhutilXHPASTBinary` methods.

Closed by commit rPHUaa8c2233920a: Remove `xhpast_parse` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 9:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

bin/

xhpast_parse.php

Diff 27950

View Options

src/parser/xhpast/bin/xhpast_parse.php

Remove `xhpast_parse` methodsClosedPublicActions