Page MenuHomePhabricator
Differential D11614

Use `PhutilXHPASTBinary` methods
ClosedPublic
Actions

Authored by joshuaspence on Feb 2 2015, 10:13 AM.
Tags
None
Referenced Files
F18729646: D11614.id.diff
Sep 30 2025, 11:25 AM
F18722730: D11614.diff
Sep 29 2025, 11:22 PM
F18623945: D11614.diff
Sep 15 2025, 6:12 PM
F18609932: D11614.diff
Sep 14 2025, 3:59 AM
F18609917: D11614.diff
Sep 14 2025, 3:58 AM
F18471568: D11614.id.diff
Sep 2 2025, 7:20 PM
F18459344: D11614.diff
Sep 1 2025, 4:48 PM
F18104429: D11614.id27973.diff
Aug 10 2025, 12:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU1d6dcad840ca: Use `PhutilXHPASTBinary` methods
Summary

Use PhutilXHPASTBinary methods instead of xhpast_parse functions. Depends on D11517.

Test Plan

N/A, this is a direct swap.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27949.Feb 2 2015, 10:13 AM
joshuaspence retitled this revision from to Use `PhutilXHPASTBinary` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D11517: Create a PHP wrapper class for the XHPAST binary.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 2 2015, 10:13 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Feb 2 2015, 1:57 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2015, 1:57 PM
joshuaspence updated this object.Feb 2 2015, 7:57 PM
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence edited edge metadata.
Closed by commit rPHU1d6dcad840ca: Use `PhutilXHPASTBinary` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyFeb 2 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence mentioned this in D11615: Remove `xhpast_parse` methods.Feb 2 2015, 8:00 PM
joshuaspence mentioned this in rPHUaa8c2233920a: Remove `xhpast_parse` methods.Feb 2 2015, 9:03 PM

Revision Contents
Changeset List

PathSize
src/
markup/
syntax/
engine/
2 lines
highlighter/
2 lines
parser/
xhpast/
__tests__/
2 lines
api/
2 lines

Diff 27973

View Options

src/markup/syntax/engine/PhutilDefaultSyntaxHighlighterEngine.php

Loading...
View Options

src/markup/syntax/highlighter/PhutilXHPASTSyntaxHighlighter.php

Loading...
View Options

src/parser/xhpast/__tests__/PHPASTParserTestCase.php

Loading...
View Options

src/parser/xhpast/api/XHPASTTree.php

Loading...
Phabricator · Built by Phacility