HomePhabricator

Build XHPAST earlier in the stack

Description

Build XHPAST earlier in the stack

Summary:
Currently, the PhutilLibraryMapBuilder will fail in an obscure way if the XHPAST binary is not built. The issue is that phutil_symbols.php will attempt to build the XHPAST binary, and this will happen eight times concurrently. Ultimately, this will fail with:

<libphutil>/scripts/build_xhpast.sh: line 24: ./xhpast: Text file busy

Test Plan: See D11528.

Reviewers: epriestley, Blessed Reviewers

Reviewed By: epriestley, Blessed Reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11627

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Feb 2 2015, 8:57 PM
Reviewer
Blessed Reviewers
Differential Revision
D11627: Build XHPAST earlier in the stack
Parents
rPHU1d6dcad840ca: Use `PhutilXHPASTBinary` methods
Branches
Unknown
Tags
Unknown