Page MenuHomePhabricator
Differential D11460

Don't create mentions for dependent diffs
ClosedPublic
Actions

Authored by joshuaspence on Jan 21 2015, 12:14 PM.
Tags
None
Referenced Files
F13216171: D11460.id27551.diff
Fri, May 17, 10:48 PM
F13214871: D11460.id27551.diff
Fri, May 17, 1:29 PM
F13209848: D11460.diff
Fri, May 17, 2:32 AM
F13203919: D11460.diff
Wed, May 15, 12:13 AM
F13186565: D11460.diff
Sat, May 11, 3:42 AM
Unknown Object (File)
Tue, May 7, 2:42 PM
Unknown Object (File)
Tue, May 7, 7:01 AM
Unknown Object (File)
Fri, May 3, 4:59 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6858: "Depends on Dx" generates a superfluous edge
Commits
Restricted Diffusion Commit
rPc429e4a22279: Don't create mentions for dependent diffs
Summary

Fixes T6858. We shouldn't create mentions for dependent diffs.

NOTE: This won't fix the issue for existing revisions (which have the mentions edge), but I think that this is harmless.
Test Plan

Added Depends on Dxxx to a differential summary. Saw a josh added a dependent revision transaction, but no explicit mention.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27551.Jan 21 2015, 12:14 PM
joshuaspence retitled this revision from to Don't create mentions for dependent diffs.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6858: "Depends on Dx" generates a superfluous edge.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 21 2015, 12:14 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jan 21 2015, 7:50 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 27557.Jan 21 2015, 7:54 PM

Remove some dead code

epriestley accepted this revision.Jan 22 2015, 8:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2015, 8:11 PM
Closed by commit rPc429e4a22279: Don't create mentions for dependent diffs (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
9 lines

Diff 27568

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility