Page MenuHomePhabricator
Differential D11460

Don't create mentions for dependent diffs
ClosedPublic
Actions

Authored by joshuaspence on Jan 21 2015, 12:14 PM.
Tags
None
Referenced Files
F14347836: D11460.diff
Thu, Dec 19, 3:37 AM
Unknown Object (File)
Tue, Dec 17, 10:10 PM
Unknown Object (File)
Tue, Dec 17, 4:42 PM
Unknown Object (File)
Fri, Dec 13, 7:25 PM
Unknown Object (File)
Thu, Dec 12, 11:33 AM
Unknown Object (File)
Sat, Dec 7, 9:57 AM
Unknown Object (File)
Thu, Dec 5, 8:11 PM
Unknown Object (File)
Tue, Dec 3, 1:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6858: "Depends on Dx" generates a superfluous edge
Commits
Restricted Diffusion Commit
rPc429e4a22279: Don't create mentions for dependent diffs
Summary

Fixes T6858. We shouldn't create mentions for dependent diffs.

NOTE: This won't fix the issue for existing revisions (which have the mentions edge), but I think that this is harmless.
Test Plan

Added Depends on Dxxx to a differential summary. Saw a josh added a dependent revision transaction, but no explicit mention.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3981
Build 3994: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27551.Jan 21 2015, 12:14 PM
joshuaspence retitled this revision from to Don't create mentions for dependent diffs.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6858: "Depends on Dx" generates a superfluous edge.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 21 2015, 12:14 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.Jan 21 2015, 7:50 PM
joshuaspence edited edge metadata.
joshuaspence updated this revision to Diff 27557.Jan 21 2015, 7:54 PM

Remove some dead code

epriestley accepted this revision.Jan 22 2015, 8:11 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 22 2015, 8:11 PM
Closed by commit rPc429e4a22279: Don't create mentions for dependent diffs (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 22 2015, 8:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
9 lines

Diff 27557

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility