Page MenuHomePhabricator
Differential D11415

Fix visibility of `PhutilArgumentWorkflow::didConstruct` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 8:33 PM.
Tags
None
Referenced Files
F13248330: D11415.id27417.diff
Fri, May 24, 2:32 AM
F13220225: D11415.id.diff
Sun, May 19, 12:05 AM
Unknown Object (File)
Sat, May 4, 5:47 AM
Unknown Object (File)
Wed, May 1, 5:17 PM
Unknown Object (File)
Apr 27 2024, 8:33 PM
Unknown Object (File)
Apr 15 2024, 9:04 PM
Unknown Object (File)
Apr 9 2024, 7:44 PM
Unknown Object (File)
Mar 30 2024, 10:17 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPdaadf955378c: Fix visibility of `PhutilArgumentWorkflow::didConstruct` methods
Summary

Ref T6822.

Test Plan

grep. This method is only called from within PhutilArgumentWorkflow::__construct.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3878
Build 3890: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27417.Jan 15 2015, 8:33 PM
joshuaspence retitled this revision from to Fix visibility of `PhutilArgumentWorkflow::didConstruct` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 8:33 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 8:38 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 8:38 PM
Closed by commit rPdaadf955378c: Fix visibility of `PhutilArgumentWorkflow::didConstruct` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
aphlict/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
audit/
management/
2 lines
celerity/
management/
2 lines
conduit/
ssh/
2 lines
daemon/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
diffusion/
ssh/
2 lines
2 lines
2 lines
2 lines
diviner/
workflow/
2 lines
2 lines
drydock/
management/
2 lines
2 lines
2 lines
2 lines
fact/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
files/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
harbormaster/
management/
2 lines
2 lines
repository/
management/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
system/
management/
2 lines
2 lines
infrastructure/
daemon/
workers/
management/
2 lines
2 lines
2 lines
2 lines
internationalization/
management/
2 lines
storage/
management/
workflow/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines

Diff 27417

View Options

src/applications/almanac/management/AlmanacManagementLockWorkflow.php

Loading...
View Options

src/applications/almanac/management/AlmanacManagementRegisterWorkflow.php

Loading...
View Options

src/applications/almanac/management/AlmanacManagementTrustKeyWorkflow.php

Loading...
View Options

src/applications/almanac/management/AlmanacManagementUnlockWorkflow.php

Loading...
View Options

src/applications/almanac/management/AlmanacManagementUntrustKeyWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementDebugWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementRestartWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStartWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStatusWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementStopWorkflow.php

Loading...
View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Loading...
View Options

src/applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php

Loading...
View Options

src/applications/celerity/management/CelerityManagementMapWorkflow.php

Loading...
View Options

src/applications/conduit/ssh/ConduitSSHWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementDebugWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementLaunchWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementListWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementRestartWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStartWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementStopWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionMercurialServeSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerAtomizeWorkflow.php

Loading...
View Options

src/applications/diviner/workflow/DivinerGenerateWorkflow.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementCloseWorkflow.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementCreateResourceWorkflow.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementReleaseWorkflow.php

Loading...
View Options

src/applications/fact/management/PhabricatorFactManagementAnalyzeWorkflow.php

Loading...
View Options

src/applications/fact/management/PhabricatorFactManagementCursorsWorkflow.php

Loading...
View Options

src/applications/fact/management/PhabricatorFactManagementDestroyWorkflow.php

Loading...
View Options

src/applications/fact/management/PhabricatorFactManagementListWorkflow.php

Loading...
View Options

src/applications/fact/management/PhabricatorFactManagementStatusWorkflow.php

Loading...
View Options

src/applications/files/management/PhabricatorFilesManagementCompactWorkflow.php

Loading...
View Options

src/applications/files/management/PhabricatorFilesManagementEnginesWorkflow.php

Loading...
View Options

src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php

Loading...
View Options

src/applications/files/management/PhabricatorFilesManagementPurgeWorkflow.php

Loading...
View Options

src/applications/files/management/PhabricatorFilesManagementRebuildWorkflow.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementBuildWorkflow.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementUpdateWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementDiscoverWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementEditWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementImportingWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementListWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementLookupUsersWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMarkImportedWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementMirrorWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementParentsWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementRefsWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementReparseWorkflow.php

Loading...
View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

Loading...
View Options

src/applications/system/management/PhabricatorSystemRemoveDestroyWorkflow.php

Loading...
View Options

src/applications/system/management/PhabricatorSystemRemoveLogWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementCancelWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementFloodWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementFreeWorkflow.php

Loading...
View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerManagementRetryWorkflow.php

Loading...
View Options

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementExtractWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementAdjustWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDatabasesWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDestroyWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementProbeWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementQuickstartWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementStatusWorkflow.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementUpgradeWorkflow.php

Loading...
Phabricator · Built by Phacility