Page MenuHomePhabricator
Differential D11411

Fix visibility of `DiffusionLowLevelQuery::executeQuery()` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:41 PM.
Tags
None
Referenced Files
F13225048: D11411.id.diff
Sun, May 19, 1:06 PM
F13221461: D11411.diff
Sun, May 19, 2:47 AM
F13203996: D11411.diff
Wed, May 15, 12:16 AM
F13189335: D11411.diff
Sat, May 11, 5:52 AM
Unknown Object (File)
Sat, Apr 27, 8:33 PM
Unknown Object (File)
Wed, Apr 24, 11:44 PM
Unknown Object (File)
Mon, Apr 22, 9:03 AM
Unknown Object (File)
Apr 15 2024, 9:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP6ff5eed20656: Fix visibility of `DiffusionLowLevelQuery::executeQuery()` methods
Summary

Ref T6822.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3872
Build 3884: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27402.Jan 15 2015, 12:41 PM
joshuaspence retitled this revision from to Fix visibility of `DiffusionLowLevelQuery::executeQuery()` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:41 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 2:25 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:25 PM
Closed by commit rP6ff5eed20656: Fix visibility of `DiffusionLowLevelQuery::executeQuery()` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 7:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27402

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelParentsQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
Phabricator · Built by Phacility