Severity	Location	Code	Message
Error	src/parser/__tests__/json/base64.data:1	TXT4	File Does Not End in Newline
Warning	src/parser/__tests__/json/base64.data:1	TXT3	Line Too Long
Warning	src/parser/__tests__/json/base64.json:1	TXT3	Line Too Long

Unit

Tests Passed

Build Status

Buildable 3752
Build 3763: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27194.Jan 11 2015, 10:29 AM

joshuaspence retitled this revision from to Fix a possible segfault when parsing JSON containing very large strings.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 11 2015, 10:29 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I think that even with (?:...) we can blow the stack -- see phutil_is_utf8_slowly() -- but the limits are high enough to be reasonable.

This revision is now accepted and ready to land.Jan 11 2015, 5:01 PM

Closed by commit rPHUbd0d806758e5: Fix a possible segfault when parsing JSON containing very large strings (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 11 2015, 7:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

.editorconfig

3 lines

externals/

jsonlint/

src/

Seld/

JsonLint/

Lexer.php

2 lines

src/

parser/

__tests__/

PhutilJSONParserTestCase.php

9 lines

json/

base64.data

1 line

base64.json

1 line

Diff 27194

View Options

.editorconfig

View Options

externals/jsonlint/src/Seld/JsonLint/Lexer.php

View Options

src/parser/tests/PhutilJSONParserTestCase.php

View Options

src/parser/tests/json/base64.data

View Options

src/parser/tests/json/base64.json

Fix a possible segfault when parsing JSON containing very large stringsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27194

.editorconfig

externals/jsonlint/src/Seld/JsonLint/Lexer.php

src/parser/__tests__/PhutilJSONParserTestCase.php

src/parser/__tests__/json/base64.data

src/parser/__tests__/json/base64.json

Fix a possible segfault when parsing JSON containing very large strings
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/PhutilJSONParserTestCase.php

src/parser/tests/json/base64.data

src/parser/tests/json/base64.json