Page MenuHomePhabricator

Fix a possible segfault when parsing JSON containing very large strings
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 10:29 AM.
Tags
None
Referenced Files
F12838206: D11323.id27209.diff
Thu, Mar 28, 6:00 PM
Unknown Object (File)
Mon, Mar 25, 6:36 PM
Unknown Object (File)
Sun, Mar 10, 4:52 AM
Unknown Object (File)
Feb 10 2024, 10:10 AM
Unknown Object (File)
Feb 8 2024, 7:19 AM
Unknown Object (File)
Jan 29 2024, 10:32 PM
Unknown Object (File)
Jan 17 2024, 8:15 AM
Unknown Object (File)
Dec 27 2023, 6:02 AM
Subscribers

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/parser/__tests__/json/base64.data:1TXT4File Does Not End in Newline
Warningsrc/parser/__tests__/json/base64.data:1TXT3Line Too Long
Warningsrc/parser/__tests__/json/base64.json:1TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 3752
Build 3763: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix a possible segfault when parsing JSON containing very large strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think that even with (?:...) we can blow the stack -- see phutil_is_utf8_slowly() -- but the limits are high enough to be reasonable.

This revision is now accepted and ready to land.Jan 11 2015, 5:01 PM
This revision was automatically updated to reflect the committed changes.