Page MenuHomePhabricator

Fix a possible segfault when parsing JSON containing very large strings
ClosedPublic

Authored by joshuaspence on Jan 11 2015, 10:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 7:35 AM
Unknown Object (File)
Sat, Nov 23, 10:37 AM
Unknown Object (File)
Mon, Nov 18, 11:29 AM
Unknown Object (File)
Mon, Nov 18, 11:29 AM
Unknown Object (File)
Mon, Nov 18, 11:29 AM
Unknown Object (File)
Mon, Nov 18, 11:16 AM
Unknown Object (File)
Oct 23 2024, 12:27 PM
Unknown Object (File)
Oct 1 2024, 3:03 PM
Subscribers

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/parser/__tests__/json/base64.data:1TXT4File Does Not End in Newline
Warningsrc/parser/__tests__/json/base64.data:1TXT3Line Too Long
Warningsrc/parser/__tests__/json/base64.json:1TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 3752
Build 3763: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix a possible segfault when parsing JSON containing very large strings.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

I think that even with (?:...) we can blow the stack -- see phutil_is_utf8_slowly() -- but the limits are high enough to be reasonable.

This revision is now accepted and ready to land.Jan 11 2015, 5:01 PM
This revision was automatically updated to reflect the committed changes.