Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHUbd0d806758e5: Fix a possible segfault when parsing JSON containing very large strings
Ported the test case from https://github.com/Seldaek/jsonlint/issues/25.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Errors Severity Location Code Message Error src/parser/__tests__/json/base64.data:1 TXT4 File Does Not End in Newline Warning src/parser/__tests__/json/base64.data:1 TXT3 Line Too Long Warning src/parser/__tests__/json/base64.json:1 TXT3 Line Too Long - Unit
Tests Passed - Build Status
Buildable 3752 Build 3763: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think that even with (?:...) we can blow the stack -- see phutil_is_utf8_slowly() -- but the limits are high enough to be reasonable.