Page MenuHomePhabricator

Cache the version for external linters
AbandonedPublic

Authored by joshuaspence on Jan 11 2015, 5:57 AM.
Tags
None
Referenced Files
F13232744: D11315.diff
Tue, May 21, 1:28 AM
F13188114: D11315.diff
Sat, May 11, 5:02 AM
Unknown Object (File)
Tue, May 7, 8:38 AM
Unknown Object (File)
Fri, May 3, 8:12 AM
Unknown Object (File)
Thu, Apr 25, 2:28 AM
Unknown Object (File)
Apr 17 2024, 2:57 PM
Unknown Object (File)
Apr 11 2024, 1:52 AM
Unknown Object (File)
Apr 5 2024, 10:11 AM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

Currently there are no safeguards in place to prevent us from making lots of calls to $EXTERNAL_LINTER --version (which is a relatively slow operation). Instead, we can provide a simple cacheing mechanism (using a static variable) in ArcanistExternalLinter. This mainly affects the unit tests of rARC, but there may be other situations in which this will yield performance improvements.

Test Plan

Before

> time ./bin/arc unit -- src/lint/linter
real    0m38.472s
user    0m35.614s
sys 0m3.536s

After

> time ./bin/arc unit -- src/lint/linter
real    0m27.364s
user    0m25.601s
sys 0m2.338s

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3742
Build 3753: [Placeholder Plan] Wait for 30 Seconds