Page MenuHomePhabricator

Cache the version for external linters
AbandonedPublic

Authored by joshuaspence on Jan 11 2015, 5:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 23, 2:30 AM
Unknown Object (File)
Tue, Apr 22, 1:29 PM
Unknown Object (File)
Apr 14 2025, 3:24 AM
Unknown Object (File)
Apr 6 2025, 2:58 AM
Unknown Object (File)
Apr 4 2025, 12:46 PM
Unknown Object (File)
Mar 29 2025, 5:00 AM
Unknown Object (File)
Mar 24 2025, 4:44 AM
Unknown Object (File)
Mar 23 2025, 3:21 PM
Subscribers

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Summary

Currently there are no safeguards in place to prevent us from making lots of calls to $EXTERNAL_LINTER --version (which is a relatively slow operation). Instead, we can provide a simple cacheing mechanism (using a static variable) in ArcanistExternalLinter. This mainly affects the unit tests of rARC, but there may be other situations in which this will yield performance improvements.

Test Plan

Before

> time ./bin/arc unit -- src/lint/linter
real    0m38.472s
user    0m35.614s
sys 0m3.536s

After

> time ./bin/arc unit -- src/lint/linter
real    0m27.364s
user    0m25.601s
sys 0m2.338s

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3742
Build 3753: [Placeholder Plan] Wait for 30 Seconds