Paths

Table of Contentst

Differential D11278

Explicitly declare method/property visibility
ClosedPublic
Actions

Authored by joshuaspence on Jan 8 2015, 8:55 AM.

Tags

None

Referenced Files

	F13189242: D11278.diff
	Sat, May 11, 5:48 AM

	Unknown Object (File)
	Tue, May 7, 9:38 AM

	Unknown Object (File)
	Fri, May 3, 9:34 AM

	Unknown Object (File)
	Thu, May 2, 3:26 AM

	Unknown Object (File)
	Sun, Apr 28, 4:06 AM

	Unknown Object (File)
	Thu, Apr 25, 3:08 AM

	Unknown Object (File)
	Apr 8 2024, 12:26 AM

	Unknown Object (File)
	Apr 2 2024, 7:01 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP698b7f9ea39c: Explicitly declare method/property visibility

Summary

Self-explanatory.

Test Plan

arc lint

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 3683
Build 3693: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	86 ms	AphrontIsolatedDatabaseConnectionTestCase::testTransactionRollback
	63 ms	AphrontMySQLDatabaseConnectionTestCase::testConnectionFailures
	60 ms	AphrontIsolatedDatabaseConnectionTestCase::testDeletePermitted
	79 ms	AphrontIsolatedDatabaseConnectionTestCase::testInsertGeneratesID
	70 ms	AphrontIsolatedDatabaseConnectionTestCase::testIsolation
		View Full Test Results (2 Failed · 7 Passed)

Event Timeline

joshuaspence updated this revision to Diff 27096.Jan 8 2015, 8:55 AM

joshuaspence retitled this revision from to Explicitly declare method/property visibility.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 8 2015, 8:55 AM

Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript

Test issues clearly unrelated.

This revision is now accepted and ready to land.Jan 8 2015, 4:39 PM

Closed by commit rP698b7f9ea39c: Explicitly declare method/property visibility (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 11 2015, 9:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

landing/

DifferentialLandingStrategy.php

2 lines

drydock/

controller/

DrydockController.php

2 lines

owners/

storage/

__tests__/

PhabricatorOwnersPackageTestCase.php

2 lines

phragment/

controller/

PhragmentController.php

4 lines

PhragmentRevertController.php

2 lines

PhragmentSnapshotDeleteController.php

2 lines

PhragmentSnapshotPromoteController.php

2 lines

infrastructure/

log/

PhabricatorAccessLog.php

2 lines

PhabricatorSSHLog.php

2 lines

storage/

patch/

PhabricatorSQLPatchList.php

4 lines

Diff 27096

src/applications/differential/landing/DifferentialLandingStrategy.php

Loading...

src/applications/drydock/controller/DrydockController.php

Loading...

src/applications/owners/storage/tests/PhabricatorOwnersPackageTestCase.php

Loading...

src/applications/phragment/controller/PhragmentController.php

Loading...

src/applications/phragment/controller/PhragmentRevertController.php

Loading...

src/applications/phragment/controller/PhragmentSnapshotDeleteController.php

Loading...

src/applications/phragment/controller/PhragmentSnapshotPromoteController.php

Loading...

src/infrastructure/log/PhabricatorAccessLog.php

Loading...

src/infrastructure/log/PhabricatorSSHLog.php

Loading...

src/infrastructure/storage/patch/PhabricatorSQLPatchList.php

Loading...