Page MenuHomePhabricator
Differential D11278

Explicitly declare method/property visibility
ClosedPublic
Actions

Authored by joshuaspence on Jan 8 2015, 8:55 AM.
Tags
None
Referenced Files
F18362691: D11278.diff
Wed, Aug 27, 2:47 PM
F18041119: D11278.id27232.diff
Sun, Aug 3, 4:24 AM
F17949519: D11278.diff
Thu, Jul 31, 11:38 PM
Unknown Object (File)
Jun 28 2025, 4:03 PM
Unknown Object (File)
Jun 18 2025, 7:23 AM
Unknown Object (File)
Jun 17 2025, 2:44 PM
Unknown Object (File)
Jun 17 2025, 10:58 AM
Unknown Object (File)
Jun 15 2025, 9:25 PM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP698b7f9ea39c: Explicitly declare method/property visibility
Summary

Self-explanatory.

Test Plan

arc lint

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27096.Jan 8 2015, 8:55 AM
joshuaspence retitled this revision from to Explicitly declare method/property visibility.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 8 2015, 8:55 AM
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript
epriestley accepted this revision.Jan 8 2015, 4:39 PM
epriestley edited edge metadata.

Test issues clearly unrelated.

This revision is now accepted and ready to land.Jan 8 2015, 4:39 PM
Closed by commit rP698b7f9ea39c: Explicitly declare method/property visibility (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 11 2015, 9:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
landing/
2 lines
drydock/
controller/
2 lines
owners/
storage/
__tests__/
2 lines
phragment/
controller/
4 lines
2 lines
2 lines
2 lines
infrastructure/
log/
2 lines
2 lines
storage/
patch/
4 lines

Diff 27232

View Options

src/applications/differential/landing/DifferentialLandingStrategy.php

Loading...
View Options

src/applications/drydock/controller/DrydockController.php

Loading...
View Options

src/applications/owners/storage/__tests__/PhabricatorOwnersPackageTestCase.php

Loading...
View Options

src/applications/phragment/controller/PhragmentController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentRevertController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentSnapshotDeleteController.php

Loading...
View Options

src/applications/phragment/controller/PhragmentSnapshotPromoteController.php

Loading...
View Options

src/infrastructure/log/PhabricatorAccessLog.php

Loading...
View Options

src/infrastructure/log/PhabricatorSSHLog.php

Loading...
View Options

src/infrastructure/storage/patch/PhabricatorSQLPatchList.php

Loading...
Phabricator · Built by Phacility