Page MenuHomePhabricator
Differential D11238

Fix visibility of various `ArcanistWorkflow` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:21 AM.
Tags
None
Referenced Files
F13253274: D11238.diff
Sat, May 25, 2:33 AM
F13231725: D11238.diff
Tue, May 21, 12:44 AM
F13213234: D11238.diff
Fri, May 17, 7:32 AM
F13192450: D11238.id.diff
Sun, May 12, 7:32 AM
Unknown Object (File)
Tue, May 7, 5:39 AM
Unknown Object (File)
Tue, May 7, 5:04 AM
Unknown Object (File)
Mon, May 6, 6:09 PM
Unknown Object (File)
Fri, May 3, 3:25 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
rARCc70009d90f7f: Fix visibility of various `ArcanistWorkflow` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the ArcanistShellCompleteWorkflow class.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26984.Jan 6 2015, 10:21 AM
joshuaspence retitled this revision from to Fix visibility of vairous `ArcanistWorkflow` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:21 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:30 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:51 PM
joshuaspence retitled this revision from Fix visibility of vairous `ArcanistWorkflow` methods to Fix visibility of various `ArcanistWorkflow` methods.Jan 6 2015, 8:35 PM
joshuaspence edited edge metadata.
Closed by commit rARCc70009d90f7f: Fix visibility of various `ArcanistWorkflow` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27037

View Options

src/workflow/ArcanistCallConduitWorkflow.php

Loading...
View Options

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

Loading...
View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
View Options

src/workflow/ArcanistPatchWorkflow.php

Loading...
View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Loading...
Phabricator · Built by Phacility