Page MenuHomePhabricator
Differential D11238

Fix visibility of various `ArcanistWorkflow` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:21 AM.
Tags
None
Referenced Files
F13165869: D11238.diff
Tue, May 7, 5:39 AM
F13165017: D11238.diff
Tue, May 7, 5:04 AM
F13163159: D11238.diff
Mon, May 6, 6:09 PM
Unknown Object (File)
Fri, May 3, 3:25 AM
Unknown Object (File)
Tue, Apr 30, 12:06 AM
Unknown Object (File)
Mon, Apr 29, 2:54 PM
Unknown Object (File)
Sat, Apr 27, 8:33 PM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
rARCc70009d90f7f: Fix visibility of various `ArcanistWorkflow` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the ArcanistShellCompleteWorkflow class.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3618
Build 3627: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26984.Jan 6 2015, 10:21 AM
joshuaspence retitled this revision from to Fix visibility of vairous `ArcanistWorkflow` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:21 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:30 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:51 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:51 PM
joshuaspence retitled this revision from Fix visibility of vairous `ArcanistWorkflow` methods to Fix visibility of various `ArcanistWorkflow` methods.Jan 6 2015, 8:35 PM
joshuaspence edited edge metadata.
Closed by commit rARCc70009d90f7f: Fix visibility of various `ArcanistWorkflow` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26984

View Options

src/workflow/ArcanistCallConduitWorkflow.php

Loading...
View Options

src/workflow/ArcanistGitHookPreReceiveWorkflow.php

Loading...
View Options

src/workflow/ArcanistInstallCertificateWorkflow.php

Loading...
View Options

src/workflow/ArcanistPatchWorkflow.php

Loading...
View Options

src/workflow/ArcanistShellCompleteWorkflow.php

Loading...
View Options

src/workflow/ArcanistSvnHookPreCommitWorkflow.php

Loading...
Phabricator · Built by Phacility