Page MenuHomePhabricator

Attempt to workaround non-deterministic `sort` behavior
ClosedPublic

Authored by joshuaspence on Jan 4 2015, 9:17 PM.
Tags
None
Referenced Files
F21282600: D11210.diff
Thu, Jul 9, 12:51 AM
Unknown Object (File)
Mar 29 2026, 9:23 AM
Unknown Object (File)
Mar 10 2026, 7:39 PM
Unknown Object (File)
Mar 4 2026, 8:51 AM
Unknown Object (File)
Feb 10 2026, 7:53 AM
Unknown Object (File)
Feb 10 2026, 7:53 AM
Unknown Object (File)
Feb 5 2026, 5:45 PM
Unknown Object (File)
Jan 12 2026, 5:56 PM
Subscribers

Details

Summary

Ref T6861. Some discussion in IRC. The behavior of sort is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings.

Test Plan

@epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch_1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3565
Build 3573: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Attempt to workaround non-deterministic `sort` behavior.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a subscriber: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 9:22 PM
This revision was automatically updated to reflect the committed changes.