Page MenuHomePhabricator
Differential D11210

Attempt to workaround non-deterministic `sort` behavior
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 9:17 PM.
Tags
None
Referenced Files
F13206739: D11210.id26912.diff
Wed, May 15, 5:14 PM
F13202757: D11210.diff
Tue, May 14, 11:05 PM
F13185145: D11210.diff
Sat, May 11, 2:38 AM
Unknown Object (File)
Tue, May 7, 4:58 AM
Unknown Object (File)
Fri, May 3, 2:14 AM
Unknown Object (File)
Mon, Apr 22, 10:30 PM
Unknown Object (File)
Thu, Apr 18, 11:54 PM
Unknown Object (File)
Apr 11 2024, 6:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6861: PHP sort function is unpredictable to human minds when dealing with mixed types
Commits
Restricted Diffusion Commit
rP85b26964f1b8: Attempt to workaround non-deterministic `sort` behavior
Summary

Ref T6861. Some discussion in IRC. The behavior of sort is somewhat broken when dealing with mixed types. In this particular case, we have both integers and strings.

Test Plan

@epriestley confirmed that this made the ordering of the Celerity map slightly-more-sane.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch_1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3565
Build 3573: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26912.Jan 4 2015, 9:17 PM
joshuaspence retitled this revision from to Attempt to workaround non-deterministic `sort` behavior.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a subscriber: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 9:17 PM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this object.Jan 4 2015, 9:19 PM
joshuaspence edited edge metadata.
joshuaspence added a task: T6861: PHP sort function is unpredictable to human minds when dealing with mixed types.
epriestley accepted this revision.Jan 4 2015, 9:22 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2015, 9:22 PM
Closed by commit rP85b26964f1b8: Attempt to workaround non-deterministic `sort` behavior (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 9:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
celerity/
8 lines

Diff 26912

View Options

src/applications/celerity/CelerityResourceMapGenerator.php

Loading...
Phabricator · Built by Phacility