Paths

Table of Contentst

Differential D11196

Ignore environment variables for `coffeelint`
ClosedPublic
Actions

Authored by joshuaspence on Jan 4 2015, 8:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 1, 4:45 AM

	Unknown Object (File)
	Fri, Dec 13, 9:50 AM

	Unknown Object (File)
	Dec 9 2024, 9:10 AM

	Unknown Object (File)
	Dec 4 2024, 9:29 PM

	Unknown Object (File)
	Nov 29 2024, 9:13 PM

	Unknown Object (File)
	Nov 27 2024, 3:48 AM

	Unknown Object (File)
	Nov 26 2024, 10:59 PM

	Unknown Object (File)
	Nov 23 2024, 2:26 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCf6b3f3c46a04: Ignore environment variables for `coffeelint`

Summary

According to coffeelint --help, --noconfig ignores the environment variable COFFEELINT_CONFIG. This means that arc lint will behave more consistently across developer workstations by forcing configuration to be specified with coffeelint.config instead of with environment variables.

Test Plan

This is mostly theoretical.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3548
Build 3556: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 26869.Jan 4 2015, 8:38 AM

joshuaspence retitled this revision from to Ignore environment variables for `coffeelint`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 4 2015, 8:38 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence updated this object.Jan 4 2015, 9:32 AM

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

epriestley accepted this revision.Jan 4 2015, 4:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 4 2015, 4:34 PM

Closed by commit rARCf6b3f3c46a04: Ignore environment variables for `coffeelint` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 4 2015, 7:49 PM

This revision was automatically updated to reflect the committed changes.

@joshuaspence Sad to say the theory is wrong, this options disables reading any config at all:
https://github.com/clutchski/coffeelint/blob/48cd906b4b403cc7e949fe5e630a89dd413c6ba6/src/commandline.coffee#L65
https://github.com/clutchski/coffeelint/blob/48cd906b4b403cc7e949fe5e630a89dd413c6ba6/src/commandline.coffee#L190

I'll make a diff to revert this.

PS not coffeelint.config but coffeelint.json is the default place.

• jjoos mentioned this in D11250: Remove the noconfig flag.Jan 6 2015, 12:58 PM

It is confirmed that this is a bug in the coffeelint docs: https://github.com/clutchski/coffeelint/pull/364

epriestley mentioned this in rARC439413ae29b5: Remove the noconfig flag.Jan 6 2015, 2:59 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistCoffeeLintLinter.php

1 line

Diff 26869

src/lint/linter/ArcanistCoffeeLintLinter.php

Loading...