Remove the noconfig flag
Summary:
D11196 introduced a regression that made it impossible for coffeelint to read any configuration. I'm reverting the change in that diff.
Created a pull request changing the documentation of coffeelint to make sure I'm interpreting this flag correctly: https://github.com/clutchski/coffeelint/pull/364
Test Plan:
- patch
- npm install -g coffeelint
- create a test.coffee file with:
# 1234567890
- arc lint test.coffee
OKAY No lint warnings.
- create a coffeelint.json with
{
"max_line_length": {
"value": 10
}
}- arc lint test.coffee, expected output:
>>> Lint for test.coffee:
Error (COFFEE)
Line exceeds maximum allowed length.
>>> 1 # 1234567890- create a .arclint with
{
"linters": {
"coffeelint": {
"type": "coffeelint",
"coffeelint.config": "coffee_lint_config_with_different_name.json"
}
}
}- rename coffeelint.json to coffee_lint_config_with_different_name.json
- arc lint test.coffee, expected output:
>>> Lint for test.coffee:
Error (COFFEE)
Line exceeds maximum allowed length.
>>> 1 # 1234567890Reviewers: Korvin, joshuaspence, epriestley, Blessed Reviewers
Reviewed By: epriestley, Blessed Reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11250