Paths

Table of Contentst

Diffusion Arcanist f5db41917be6

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
f5db41917be6
Actions

Description

Reduce boilerplate code in ArcanistLinterTestCase subclasses

Summary: This is a bit magical and is maybe a terrible idea, but it seems okayish.

Test Plan: arc unit

Reviewers: chad, Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11172

Details

Provenance

joshuaspence	Authored on
joshuaspence	Pushed on Jan 4 2015, 7:44 AM

Reviewer

Blessed Reviewers

Differential Revision

D11172: Reduce boilerplate code in `ArcanistLinterTestCase` subclasses

Parents

rARCa10002adec13: Raise a linter error when removed symbols are used

Branches

Unknown

Tags

Unknown

Event Timeline

joshuaspence committed rARCf5db41917be6: Reduce boilerplate code in `ArcanistLinterTestCase` subclasses (authored by joshuaspence).Jan 4 2015, 7:40 AM

joshuaspence added a project: Blessed Reviewers.Jan 4 2015, 7:44 AM

Changes (27)

Path

Size

src/

lint/

linter/

__tests__/

ArcanistCSSLintLinterTestCase.php

ArcanistClosureLinterTestCase.php

ArcanistCoffeeLintLinterTestCase.php

ArcanistCommitLinterTestCase.php

ArcanistCppcheckLinterTestCase.php

ArcanistCpplintLinterTestCase.php

ArcanistFlake8LinterTestCase.php

ArcanistGoLintLinterTestCase.php

ArcanistHLintLinterTestCase.php

ArcanistJSHintLinterTestCase.php

ArcanistJSONLintLinterTestCase.php

ArcanistJSONLinterTestCase.php

ArcanistJscsLinterTestCase.php

ArcanistLesscLinterTestCase.php

ArcanistLinterTestCase.php

ArcanistMergeConflictLinterTestCase.php

ArcanistPEP8LinterTestCase.php

ArcanistPhpLinterTestCase.php

ArcanistPhpcsLinterTestCase.php

ArcanistPhutilXHPASTLinterTestCase.php

ArcanistPuppetLintLinterTestCase.php

ArcanistPyFlakesLinterTestCase.php

ArcanistPyLintLinterTestCase.php

ArcanistRubyLinterTestCase.php

ArcanistTextLinterTestCase.php

ArcanistXHPASTLinterTestCase.php

ArcanistXMLLinterTestCase.php

rARCf5db41917be6

View Options

src/lint/linter/tests/ArcanistCSSLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistClosureLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistCoffeeLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistCommitLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistCppcheckLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistCpplintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistFlake8LinterTestCase.php

View Options

src/lint/linter/tests/ArcanistGoLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistHLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistJSHintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistJSONLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistJSONLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistJscsLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistLesscLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistMergeConflictLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPEP8LinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPhpLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPhpcsLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPhutilXHPASTLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPuppetLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPyFlakesLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistPyLintLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistRubyLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistTextLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistXHPASTLinterTestCase.php

View Options

src/lint/linter/tests/ArcanistXMLLinterTestCase.php

Reduce boilerplate code in `ArcanistLinterTestCase` subclassesf5db41917be6Actions

Description

Details

Event Timeline

Changes (27)

rARCf5db41917be6

src/lint/linter/__tests__/ArcanistCSSLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistClosureLinterTestCase.php

src/lint/linter/__tests__/ArcanistCoffeeLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistCommitLinterTestCase.php

src/lint/linter/__tests__/ArcanistCppcheckLinterTestCase.php

src/lint/linter/__tests__/ArcanistCpplintLinterTestCase.php

src/lint/linter/__tests__/ArcanistFlake8LinterTestCase.php

src/lint/linter/__tests__/ArcanistGoLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistHLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistJSHintLinterTestCase.php

src/lint/linter/__tests__/ArcanistJSONLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistJSONLinterTestCase.php

src/lint/linter/__tests__/ArcanistJscsLinterTestCase.php

src/lint/linter/__tests__/ArcanistLesscLinterTestCase.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/__tests__/ArcanistMergeConflictLinterTestCase.php

src/lint/linter/__tests__/ArcanistPEP8LinterTestCase.php

src/lint/linter/__tests__/ArcanistPhpLinterTestCase.php

src/lint/linter/__tests__/ArcanistPhpcsLinterTestCase.php

src/lint/linter/__tests__/ArcanistPhutilXHPASTLinterTestCase.php

src/lint/linter/__tests__/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistPyFlakesLinterTestCase.php

src/lint/linter/__tests__/ArcanistPyLintLinterTestCase.php

src/lint/linter/__tests__/ArcanistRubyLinterTestCase.php

src/lint/linter/__tests__/ArcanistTextLinterTestCase.php

src/lint/linter/__tests__/ArcanistXHPASTLinterTestCase.php

src/lint/linter/__tests__/ArcanistXMLLinterTestCase.php

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
f5db41917be6
Actions

src/lint/linter/tests/ArcanistCSSLintLinterTestCase.php

src/lint/linter/tests/ArcanistClosureLinterTestCase.php

src/lint/linter/tests/ArcanistCoffeeLintLinterTestCase.php

src/lint/linter/tests/ArcanistCommitLinterTestCase.php

src/lint/linter/tests/ArcanistCppcheckLinterTestCase.php

src/lint/linter/tests/ArcanistCpplintLinterTestCase.php

src/lint/linter/tests/ArcanistFlake8LinterTestCase.php

src/lint/linter/tests/ArcanistGoLintLinterTestCase.php

src/lint/linter/tests/ArcanistHLintLinterTestCase.php

src/lint/linter/tests/ArcanistJSHintLinterTestCase.php

src/lint/linter/tests/ArcanistJSONLintLinterTestCase.php

src/lint/linter/tests/ArcanistJSONLinterTestCase.php

src/lint/linter/tests/ArcanistJscsLinterTestCase.php

src/lint/linter/tests/ArcanistLesscLinterTestCase.php

src/lint/linter/tests/ArcanistLinterTestCase.php

src/lint/linter/tests/ArcanistMergeConflictLinterTestCase.php

src/lint/linter/tests/ArcanistPEP8LinterTestCase.php

src/lint/linter/tests/ArcanistPhpLinterTestCase.php

src/lint/linter/tests/ArcanistPhpcsLinterTestCase.php

src/lint/linter/tests/ArcanistPhutilXHPASTLinterTestCase.php

src/lint/linter/tests/ArcanistPuppetLintLinterTestCase.php

src/lint/linter/tests/ArcanistPyFlakesLinterTestCase.php

src/lint/linter/tests/ArcanistPyLintLinterTestCase.php

src/lint/linter/tests/ArcanistRubyLinterTestCase.php

src/lint/linter/tests/ArcanistTextLinterTestCase.php

src/lint/linter/tests/ArcanistXHPASTLinterTestCase.php

src/lint/linter/tests/ArcanistXMLLinterTestCase.php