Page MenuHomePhabricator

Rename `PhabricatorPolicyRule` subclasses for consistency
ClosedPublic

Authored by joshuaspence on Jan 3 2015, 1:06 AM.
Tags
None
Referenced Files
F13095445: D11166.id26813.diff
Thu, Apr 25, 9:33 AM
F13090273: D11166.diff
Thu, Apr 25, 2:17 AM
Unknown Object (File)
Thu, Apr 18, 7:07 AM
Unknown Object (File)
Thu, Apr 11, 9:41 AM
Unknown Object (File)
Sat, Mar 30, 4:26 PM
Unknown Object (File)
Fri, Mar 29, 10:25 AM
Unknown Object (File)
Thu, Mar 28, 3:28 PM
Unknown Object (File)
Mar 25 2024, 1:52 PM
Subscribers

Details

Summary

Ref T5655. Fixes T6849. This is another take on D11131, which was missing the DB migration and was reverted in rP7c4de0f6be77ddaea593e1f41ae27211ec179a55.

Test Plan

Ran ./bin/storage upgrade and verified that the classes were renamed in the phabricator_policy.policy table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Rename `PhabricatorPolicyRule` subclasses for consistency.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Fixed migration

joshuaspence edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.

This applied cleanly locally and looks good to me.

resources/sql/autopatches/20150102.policyname.php
20

(This comment is copy/paste from elsewhere maybe?)

This revision is now accepted and ready to land.Jan 3 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.