Page MenuHomePhabricator

Rename `PhabricatorPolicyRule` subclasses for consistency
ClosedPublic

Authored by joshuaspence on Jan 3 2015, 1:06 AM.

Details

Summary

Ref T5655. Fixes T6849. This is another take on D11131, which was missing the DB migration and was reverted in rP7c4de0f6be77ddaea593e1f41ae27211ec179a55.

Test Plan

Ran ./bin/storage upgrade and verified that the classes were renamed in the phabricator_policy.policy table.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 3509
Build 3517: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Rename `PhabricatorPolicyRule` subclasses for consistency.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Fixed migration

joshuaspence updated this object.Jan 3 2015, 1:20 AM
joshuaspence edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Jan 3 2015, 12:22 PM
epriestley edited edge metadata.

This applied cleanly locally and looks good to me.

resources/sql/autopatches/20150102.policyname.php
19

(This comment is copy/paste from elsewhere maybe?)

This revision is now accepted and ready to land.Jan 3 2015, 12:23 PM
This revision was automatically updated to reflect the committed changes.