Page MenuHomePhabricator

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
ClosedPublic

Authored by joshuaspence on Jan 3 2015, 4:53 AM.
Tags
None
Referenced Files
F13151745: D11172.diff
Sat, May 4, 6:47 PM
Unknown Object (File)
Thu, May 2, 6:40 PM
Unknown Object (File)
Wed, May 1, 12:09 AM
Unknown Object (File)
Sun, Apr 28, 6:49 AM
Unknown Object (File)
Fri, Apr 19, 2:11 AM
Unknown Object (File)
Wed, Apr 17, 2:53 PM
Unknown Object (File)
Apr 3 2024, 12:47 PM
Unknown Object (File)
Mar 15 2024, 1:40 PM
Subscribers

Details

Summary

This is a bit magical and is maybe a terrible idea, but it seems okayish.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3516
Build 3524: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Reduce boilerplate code in `ArcanistLinterTestCase` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Seems fine to me, I can't come up with a way that this would ever do the wrong thing.

This revision is now accepted and ready to land.Jan 3 2015, 12:33 PM
This revision was automatically updated to reflect the committed changes.