Page MenuHomePhabricator

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
ClosedPublic

Authored by joshuaspence on Jan 3 2015, 4:53 AM.
Tags
None
Referenced Files
F15410732: D11172.diff
Wed, Mar 19, 8:18 AM
F15338911: D11172.id26822.diff
Sun, Mar 9, 1:25 PM
F15284119: D11172.diff
Tue, Mar 4, 9:14 AM
Unknown Object (File)
Sat, Feb 22, 5:34 AM
Unknown Object (File)
Feb 18 2025, 3:18 PM
Unknown Object (File)
Feb 8 2025, 12:43 AM
Unknown Object (File)
Feb 8 2025, 12:43 AM
Unknown Object (File)
Feb 8 2025, 12:43 AM
Subscribers

Details

Summary

This is a bit magical and is maybe a terrible idea, but it seems okayish.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3516
Build 3524: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Reduce boilerplate code in `ArcanistLinterTestCase` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Seems fine to me, I can't come up with a way that this would ever do the wrong thing.

This revision is now accepted and ready to land.Jan 3 2015, 12:33 PM
This revision was automatically updated to reflect the committed changes.