Page MenuHomePhabricator

Reduce boilerplate code in `ArcanistLinterTestCase` subclasses
ClosedPublic

Authored by joshuaspence on Jan 3 2015, 4:53 AM.
Tags
None
Referenced Files
F19147126: D11172.diff
Wed, Dec 10, 4:02 PM
F19146898: D11172.diff
Wed, Dec 10, 3:48 PM
F19059943: D11172.id.diff
Sat, Nov 29, 7:13 AM
F19053494: D11172.diff
Fri, Nov 28, 9:06 AM
F18952672: D11172.diff
Nov 12 2025, 6:22 AM
F18822474: D11172.id.diff
Oct 23 2025, 6:58 AM
F18820577: D11172.diff
Oct 22 2025, 4:01 PM
F18817584: D11172.id26822.diff
Oct 21 2025, 4:44 PM
Subscribers

Details

Summary

This is a bit magical and is maybe a terrible idea, but it seems okayish.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3516
Build 3524: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Reduce boilerplate code in `ArcanistLinterTestCase` subclasses.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Seems fine to me, I can't come up with a way that this would ever do the wrong thing.

This revision is now accepted and ready to land.Jan 3 2015, 12:33 PM
This revision was automatically updated to reflect the committed changes.