Page MenuHomePhabricator

Fix two linter issues
ClosedPublic

Authored by epriestley on Dec 30 2014, 3:00 PM.
Tags
None
Referenced Files
F13147080: D11087.id.diff
Fri, May 3, 12:15 PM
Unknown Object (File)
Fri, May 3, 5:43 AM
Unknown Object (File)
Fri, May 3, 12:40 AM
Unknown Object (File)
Wed, May 1, 5:13 PM
Unknown Object (File)
Thu, Apr 25, 12:57 AM
Unknown Object (File)
Thu, Apr 11, 8:42 AM
Unknown Object (File)
Apr 3 2024, 1:23 PM
Unknown Object (File)
Feb 16 2024, 11:21 AM
Subscribers

Details

Summary
  • The "exclude static variable access" branch in XHPAST incorrectly excluded all variables in a function or method which used any static access (we were selecting the wrong root node for exclusion).
  • The "PHPLinter" regexp did not work with 5.4.30. Make it more permissive in what it parses.
Test Plan
  • Added a failing unit test for the variable case and made it pass.
  • PHPLinter tests now pass under 5.4.30

Diff Detail

Repository
rARC Arcanist
Branch
varlint
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 3390
Build 3397: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix two linter issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
btrahan edited edge metadata.

Yay test coverage

This revision is now accepted and ready to land.Dec 30 2014, 6:01 PM
This revision was automatically updated to reflect the committed changes.