Page MenuHomePhabricator
Differential D11078

Use `new FutureIterator` instead of `Futures`
ClosedPublic
Actions

Authored by joshuaspence on Dec 30 2014, 12:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 5:06 AM
Unknown Object (File)
Mon, Jan 27, 10:07 AM
Unknown Object (File)
Thu, Jan 23, 7:34 PM
Unknown Object (File)
Thu, Jan 23, 7:34 PM
Unknown Object (File)
Thu, Jan 23, 7:34 PM
Unknown Object (File)
Tue, Jan 21, 9:16 AM
Unknown Object (File)
Wed, Jan 15, 4:53 PM
Unknown Object (File)
Mon, Jan 13, 1:02 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6829: The `Futures()` function violates naming conventions
Commits
rPHUe6fef2c60a35: Use `new FutureIterator` instead of `Futures`
Summary

Ref T6829. Deprecate the Futures() function.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26592.Dec 30 2014, 12:07 PM
joshuaspence retitled this revision from to Use `new FutureIterator` instead of `Futures`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6829: The `Futures()` function violates naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2014, 12:07 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Dec 30 2014, 12:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:08 PM
joshuaspence mentioned this in D11081: Remove the `Futures()` method.Dec 30 2014, 12:21 PM
Closed by commit rPHUe6fef2c60a35: Use `new FutureIterator` instead of `Futures` (authored by joshuaspence, committed by joshuaspence). · Explain WhyDec 30 2014, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
filesystem/
__tests__/
3 lines
future/
10 lines
exec/
__tests__/
2 lines
query/
2 lines
moduleutils/
4 lines

Diff 26600

View Options

src/filesystem/__tests__/PhutilDeferredLogTestCase.php

Loading...
View Options

src/future/FutureIterator.php

Loading...
View Options

src/future/exec/__tests__/ExecFutureTestCase.php

Loading...
View Options

src/future/query/QueryFuture.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
Phabricator · Built by Phacility