Page MenuHomePhabricator

Remove the `Futures()` method
ClosedPublic

Authored by joshuaspence on Dec 30 2014, 12:21 PM.
Tags
None
Referenced Files
F15262494: D11081.id26597.diff
Tue, Feb 25, 12:31 PM
Unknown Object (File)
Fri, Feb 21, 11:22 AM
Unknown Object (File)
Tue, Feb 18, 1:41 AM
Unknown Object (File)
Sat, Feb 8, 12:31 AM
Unknown Object (File)
Sat, Feb 8, 12:30 AM
Unknown Object (File)
Sat, Feb 8, 12:30 AM
Unknown Object (File)
Fri, Feb 7, 9:43 AM
Unknown Object (File)
Tue, Feb 4, 2:33 AM

Details

Summary

Fixes T6829. Removes the Futures() method in favor of calling new FutureIterator($futures) explicitly. Depends on D11077, D11078 and D11079.

Test Plan

We could possibly deprecate this function instead (with phutil_deprecated).

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/future/FutureIterator.php:31XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 3379
Build 3386: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley edited edge metadata.
This revision is now accepted and ready to land.Dec 30 2014, 12:33 PM

I think removing it outright is reasonable, this is a fairly advanced feature that probably has seen little/no third-party use.

This revision was automatically updated to reflect the committed changes.

A little late to vote on this now, but deprecating would have been nicer.

I ran into this error, and it took a while to realize it was using an old forked version of Arcanist:

PHP Fatal error: Call to undefined function Futures() in ~/Tools/arcanist/src/repository/api/ArcanistGitAPI.php on line 612

I think that if you've forked rARC then you should probably fork rPHU as well.