Page MenuHomePhabricator
Differential D10879

Fix issues where Drydock queries didn't work correctly with empty arrays
ClosedPublic
Actions

Authored by hach-que on Nov 19 2014, 11:11 PM.
Tags
None
Referenced Files
F13158734: D10879.diff
Sun, May 5, 9:12 PM
Unknown Object (File)
Mon, Apr 29, 8:07 PM
Unknown Object (File)
Mon, Apr 29, 6:24 AM
Unknown Object (File)
Wed, Apr 24, 11:51 PM
Unknown Object (File)
Sun, Apr 14, 12:24 PM
Unknown Object (File)
Thu, Apr 11, 8:07 AM
Unknown Object (File)
Apr 1 2024, 1:43 AM
Unknown Object (File)
Feb 26 2024, 3:42 PM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Commits
Restricted Diffusion Commit
rPe55a197dd683: Fix issues where Drydock queries didn't work correctly with empty arrays
Summary

Ref T2015. This fixes issues where the Drydock queries wouldn't filter (or throw an exception) when passed empty arrays for their with methods. In addition, this also adds array_unique to the resource and lease subqueries so that we don't pull in a bunch of stuff if logs or leases have the same related objects.

Test Plan

Tested it by using DarkConsole on the log controller.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D10879
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3130
Build 3136: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 26129.Nov 19 2014, 11:11 PM
hach-que retitled this revision from to Fix issues where Drydock queries didn't work correctly with empty arrays.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2014, 11:11 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3102: Diff 26129.Nov 19 2014, 11:12 PM
epriestley requested changes to this revision.Nov 19 2014, 11:13 PM
epriestley edited edge metadata.

Minor style nit.

src/applications/drydock/query/DrydockLogSearchEngine.php
38

Prefer just if ($resource_phids). This is equivalent to count() and simpler / consistent with the rest of the codebase.

45–61

etc etc

This revision now requires changes to proceed.Nov 19 2014, 11:13 PM
hach-que updated this revision to Diff 26134.Nov 19 2014, 11:33 PM
hach-que edited edge metadata.

Style fixes

Harbormaster completed remote builds in B3105: Diff 26134.Nov 19 2014, 11:34 PM
epriestley accepted this revision.Nov 21 2014, 7:10 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 21 2014, 7:10 PM
hach-que updated this revision to Diff 26169.Nov 22 2014, 8:47 AM
hach-que edited edge metadata.

Rebase on D10874

hach-que added a comment.Nov 22 2014, 8:47 AM

drydockblueprint1.png (690×1 px, 100 KB)

Harbormaster completed remote builds in B3130: Diff 26169.Nov 22 2014, 8:47 AM
joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:37 AM
hach-que updated this revision to Diff 33759.Aug 24 2015, 11:09 AM

Rebase

Closed by commit rPe55a197dd683: Fix issues where Drydock queries didn't work correctly with empty arrays (authored by hach-que, committed by hach-que). · Explain WhyAug 24 2015, 11:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
query/
6 lines
12 lines
12 lines
47 lines
12 lines

Diff 26169

View Options

src/applications/drydock/query/DrydockBlueprintQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockLogQuery.php

Loading...
View Options

src/applications/drydock/query/DrydockLogSearchEngine.php

Loading...
View Options

src/applications/drydock/query/DrydockResourceQuery.php

Loading...
Phabricator · Built by Phacility