Paths

Table of Contentst

Differential D10879

Fix issues where Drydock queries didn't work correctly with empty arrays
ClosedPublic
Actions

Authored by hach-que on Nov 19 2014, 11:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 20, 6:21 PM

	Unknown Object (File)
	Fri, Dec 20, 5:33 PM

	Unknown Object (File)
	Fri, Dec 20, 12:32 PM

	Unknown Object (File)
	Thu, Dec 19, 5:21 PM

	Unknown Object (File)
	Thu, Dec 19, 11:07 AM

	Unknown Object (File)
	Thu, Dec 12, 1:47 AM

	Unknown Object (File)
	Tue, Dec 10, 2:49 PM

	Unknown Object (File)
	Tue, Dec 3, 8:46 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Commits

Restricted Diffusion Commit
rPe55a197dd683: Fix issues where Drydock queries didn't work correctly with empty arrays

Summary

Ref T2015. This fixes issues where the Drydock queries wouldn't filter (or throw an exception) when passed empty arrays for their with methods. In addition, this also adds array_unique to the resource and lease subqueries so that we don't pull in a bunch of stuff if logs or leases have the same related objects.

Test Plan

Tested it by using DarkConsole on the log controller.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hach-que updated this revision to Diff 26129.Nov 19 2014, 11:11 PM

hach-que retitled this revision from to Fix issues where Drydock queries didn't work correctly with empty arrays.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T2015: Implement Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 19 2014, 11:11 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B3102: Diff 26129.Nov 19 2014, 11:12 PM

Minor style nit.

src/applications/drydock/query/DrydockLogSearchEngine.php
52	Prefer just `if ($resource_phids)`. This is equivalent to count() and simpler / consistent with the rest of the codebase.
59–75	etc etc

This revision now requires changes to proceed.Nov 19 2014, 11:13 PM

Style fixes

Harbormaster completed remote builds in B3105: Diff 26134.Nov 19 2014, 11:34 PM

epriestley accepted this revision.Nov 21 2014, 7:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Nov 21 2014, 7:10 PM

Rebase on D10874

drydockblueprint1.png (690×1 px, 100 KB)

Harbormaster completed remote builds in B3130: Diff 26169.Nov 22 2014, 8:47 AM

joshuaspence added a subscriber: joshuaspence.Feb 25 2015, 7:37 AM

Rebase

Closed by commit rPe55a197dd683: Fix issues where Drydock queries didn't work correctly with empty arrays (authored by hach-que, committed by hach-que). · Explain WhyAug 24 2015, 11:23 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

query/

DrydockBlueprintQuery.php

6 lines

DrydockLeaseQuery.php

12 lines

DrydockLogQuery.php

8 lines

DrydockLogSearchEngine.php

46 lines

DrydockResourceQuery.php

12 lines

Diff 33763

src/applications/drydock/query/DrydockBlueprintQuery.php

Loading...

src/applications/drydock/query/DrydockLeaseQuery.php

Loading...

src/applications/drydock/query/DrydockLogQuery.php

Loading...

src/applications/drydock/query/DrydockLogSearchEngine.php

Loading...

src/applications/drydock/query/DrydockResourceQuery.php

Loading...