Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T4016: Creating Projects from Maniphest should have more relevant controls
T6145: Custom project fields do not appear in the Create New Project - Commits
- Restricted Diffusion Commit
rPee8004ab4d7d: Projects - merge create + edit interface code paths
Made new projects from Maniphest - great success. Made new projects from project / create - also great success.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T6145
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2800 Build 2804: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/infrastructure/customfield/field/PhabricatorCustomFieldList.php | ||
|---|---|---|
| 86–93 ↗ | (On Diff #25642) | This was pretty dodgy but an interface seemed a bit hardcore to me. If the interface route, where would I put that bad boy? |
| src/infrastructure/customfield/field/PhabricatorCustomFieldList.php | ||
|---|---|---|
| 86–93 ↗ | (On Diff #25642) | You can use a $form on both codepaths, and then turn it into a LayoutView with $form->buildLayoutView() at the last second if it's going into a dialog. |
Comment Actions
Possibly we should have something like this on dialogs:
public function appendForm(AphrontFormView $form) {
return $this->appendChild($form->buildLayoutView());
}Comment Actions
remove jankiness and instead use AphrontFormView consistently, using new helper method $dialog->appendForm as appropos