Allows to filter phrequent user time by time ranges
Needs ReviewPublic
Actions

Authored by witrin on Oct 10 2014, 2:53 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5150: Extend query by time restrictions

Summary

Allows to query tracked user time by their dateStarted and dateEnded.

Test Plan

Open the advanced search of Phrequent and you will see two additional input fields for the begin and the end of the time range to search within. Use those fields to narrow your search results.

Diff Detail

Repository

rP Phabricator

Branch

T5150

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 2794
Build 2798: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

witrin updated this revision to Diff 25633.Oct 10 2014, 2:53 PM

witrin added a task: T5150: Extend query by time restrictions.

witrin retitled this revision from to Allows to filter phrequent user time by time ranges.

witrin updated this object.

witrin edited the test plan for this revision. (Show Details)

witrin added a reviewer: epriestley.

witrin added a subscriber: witrin.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptOct 10 2014, 2:53 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B2794: Diff 25633.Oct 10 2014, 2:54 PM

I had to create this stuff here on a local machine and had no time for a full installation of Phabricator. So I just cloned the repository and made the changes. But by using arc diff I got the following exception:

The program is attempting to read user input, but stdin is being piped from some other source (not a TTY).
(Run with --trace for a full exception trace.)
Exception
Unable to read results from background linting and unit testing. You can try running arc diff again with --background 0
(Run with --trace for a full exception trace.)

So I've skipped all that with arc diff --background 0 --nounit --nolint.

witrin edited edge metadata.Oct 10 2014, 3:03 PM

witrin added a project: Phrequent.

witrin mentioned this in D10162: Extends Phrequent search capabilities.Nov 20 2014, 2:07 AM

It's shame that such useful code is waiting years for review...

In D10674#228771, @Ondrej wrote:

It's shame that such useful code is waiting years for review...

Per policy, Phrequent is a Prototype application and thus external contributions are not accepted for it.

In D10674#228773, @asherkin wrote:

In D10674#228771, @Ondrej wrote:

It's shame that such useful code is waiting years for review...

Per policy, Phrequent is a Prototype application and thus external contributions are not accepted for it.