Page MenuHomePhabricator

Allows to filter phrequent user time by time ranges
Needs ReviewPublic

Authored by witrin on Oct 10 2014, 2:53 PM.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5150: Extend query by time restrictions
Summary

Allows to query tracked user time by their dateStarted and dateEnded.

Test Plan

Open the advanced search of Phrequent and you will see two additional input fields for the begin and the end of the time range to search within. Use those fields to narrow your search results.

Diff Detail

Repository
rP Phabricator
Branch
T5150
Lint
Lint SkippedExcuse: Got problems with arcanist here locally. Don't know.
Unit
Unit Tests Skipped
Build Status
Buildable 2794
Build 2798: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

witrin updated this revision to Diff 25633.Oct 10 2014, 2:53 PM
witrin retitled this revision from to Allows to filter phrequent user time by time ranges.
witrin updated this object.
witrin edited the test plan for this revision. (Show Details)
witrin added a reviewer: epriestley.
witrin added a subscriber: witrin.

I had to create this stuff here on a local machine and had no time for a full installation of Phabricator. So I just cloned the repository and made the changes. But by using arc diff I got the following exception:

The program is attempting to read user input, but stdin is being piped from some other source (not a TTY).
(Run with --trace for a full exception trace.)
Exception
Unable to read results from background linting and unit testing. You can try running arc diff again with --background 0
(Run with --trace for a full exception trace.)

So I've skipped all that with arc diff --background 0 --nounit --nolint.

witrin edited edge metadata.Oct 10 2014, 3:03 PM
witrin added a project: Phrequent.
Ondrej added a subscriber: Ondrej.EditedOct 20 2017, 12:26 PM

It's shame that such useful code is waiting years for review...

It's shame that such useful code is waiting years for review...

Per policy, Phrequent is a Prototype application and thus external contributions are not accepted for it.

It's shame that such useful code is waiting years for review...

Per policy, Phrequent is a Prototype application and thus external contributions are not accepted for it.

Yes, that's a shame to have a stupid policy :-)