Paths

Table of Contentst

Differential D10558

Fix `LINT_ARRAY_SEPARATOR` for nested arrays
ClosedPublic
Actions

Authored by joshuaspence on Sep 25 2014, 2:53 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCcb2007825048: Fix `LINT_ARRAY_SEPARATOR` for nested arrays

Summary

The LINT_ARRAY_SEPARATOR rule was added to ArcanistXHPASTLinter in D10535. Unfortunately, it does not correctly handle nested arrays correctly. This patch fixes this. Depends on D10554.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2636
Build 2640: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25364.Sep 25 2014, 2:53 AM

joshuaspence retitled this revision from to Fix `LINT_ARRAY_SEPARATOR` for nested arrays.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a parent revision: D10554: Add a `getChildrenOfType` method to `AASTNode`.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 25 2014, 2:53 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2636: Diff 25364.Sep 25 2014, 2:54 AM

joshuaspence mentioned this in D10554: Add a `getChildrenOfType` method to `AASTNode`.Sep 25 2014, 2:57 AM

Another possible issue:

     $keys = array(
       'key1' => mt_rand(),
       'key2' => '',
-      'key3' => 'Phabricator');
+      'key3' => 'Phabricator',);

epriestley accepted this revision.Sep 25 2014, 1:26 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 25 2014, 1:26 PM

Simplify

Harbormaster completed remote builds in B2648: Diff 25381.Sep 25 2014, 9:25 PM

Closed by commit rARCcb2007825048: Fix `LINT_ARRAY_SEPARATOR` for nested arrays (authored by joshuaspence, committed by joshuaspence).Sep 25 2014, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

32 lines

__tests__/

xhpast/

array-comma.lint-test

9 lines

Diff 25364

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/array-comma.lint-test

Fix `LINT_ARRAY_SEPARATOR` for nested arraysClosedPublicActions