Paths

Table of Contentst

Differential D10551

Fix a fatal error in `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Sep 24 2014, 9:30 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC13492c8043a4: Fix a fatal error in `ArcanistXHPASTLinter`

Summary

I had assumed that we would always be interested in n_STATEMENT_LIST, which is fine for if (...) { some_statements(); } but not for if (...) one_statement();.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2627
Build 2631: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25350.Sep 24 2014, 9:30 PM

joshuaspence retitled this revision from to Fix a fatal error in `ArcanistXHPASTLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 24 2014, 9:30 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2627: Diff 25350.Sep 24 2014, 9:30 PM

epriestley accepted this revision.Sep 24 2014, 9:32 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 24 2014, 9:32 PM

Closed by commit rARC13492c8043a4: Fix a fatal error in `ArcanistXHPASTLinter` (authored by joshuaspence, committed by joshuaspence).Sep 24 2014, 9:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

2 lines

__tests__/

xhpast/

conditional-usage.lint-test

3 lines

Diff 25350

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/conditional-usage.lint-test

Fix a fatal error in `ArcanistXHPASTLinter`ClosedPublicActions