D10551.id.diff
No OneTemporary
Actions

Size

918 B

Referenced Files

None

Subscribers

None

D10551.id.diff
View Options

	diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
	--- a/src/lint/linter/ArcanistXHPASTLinter.php
	+++ b/src/lint/linter/ArcanistXHPASTLinter.php
	@@ -426,7 +426,7 @@
	}

	$span = $conditional
	- ->getChildOfType(1, 'n_STATEMENT_LIST')
	+ ->getChildByIndex(1)
	->getTokens();

	$whitelist[$type][$symbol_name][] = range(
	diff --git a/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test b/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	--- a/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	+++ b/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	@@ -12,6 +12,9 @@
	new DateTimeImmutable();
	}

	+if (function_exists('json_last_error_msg'))
	+ json_last_error_msg();
	+
	// These shouldn't fatal.
	if (SomeClass::someStaticMethod($param)) {}
	$var = 'some_func';