Page MenuHomePhabricator
Differential D10542

Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name
AbandonedPublic
Actions

Authored by fabe on Sep 23 2014, 3:57 PM.
Tags
None
Referenced Files
F14913074: D10542.id31267.diff
Wed, Feb 12, 1:51 AM
F14913073: D10542.id27602.diff
Wed, Feb 12, 1:51 AM
F14913071: D10542.id26272.diff
Wed, Feb 12, 1:50 AM
F14913069: D10542.id25327.diff
Wed, Feb 12, 1:50 AM
F14913066: D10542.id25326.diff
Wed, Feb 12, 1:49 AM
F14913065: D10542.id.diff
Wed, Feb 12, 1:49 AM
F14913057: D10542.id25326.diff
Wed, Feb 12, 1:46 AM
Unknown Object (File)
Fri, Feb 7, 8:00 AM
View All Files
Subscribers
epriestley
joshuaspence
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8295: Show which commits were included in a merge commit in Herald emails
Summary

Add extra information about author and merges into herald commit emails

Test Plan

Create a herald email alert that hits a merge commit

Diff Detail

Repository
rP Phabricator
Branch
heraldemails
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 2614
Build 2618: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

fabe updated this revision to Diff 25326.Sep 23 2014, 3:57 PM
fabe retitled this revision from to Provide more information in Herald Commit Email notifications - Add a list of merged commits to merge commits. - Show the author's name.
fabe updated this object.
fabe edited the test plan for this revision. (Show Details)
fabe added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 23 2014, 3:57 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2613: Diff 25326.Sep 23 2014, 3:58 PM
fabe updated this revision to Diff 25327.Sep 23 2014, 4:44 PM
fabe edited edge metadata.
  • only add the author info to the body if we cannot put it into the from tag
Harbormaster completed remote builds in B2614: Diff 25327.Sep 23 2014, 4:45 PM
fabe updated this revision to Diff 26272.Dec 6 2014, 1:10 PM

rebaseing

fabe updated this revision to Diff 27602.Jan 23 2015, 12:40 PM

rebasing

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 4:13 AM
fabe updated this revision to Diff 31267.May 22 2015, 7:36 AM

rebase

fabe added a task: T8295: Show which commits were included in a merge commit in Herald emails.May 22 2015, 7:44 AM
fabe abandoned this revision.May 25 2015, 10:31 AM

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
52 lines

Diff 25327

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...
Phabricator · Built by Phacility