Page MenuHomePhabricator

restored --head support
ClosedPublic

Authored by talshiri on Sep 8 2014, 8:52 PM.
Tags
None
Referenced Files
F18807285: D10447.id25123.diff
Oct 19 2025, 12:22 AM
F18784221: D10447.id.diff
Oct 13 2025, 12:07 PM
F18769927: D10447.id25124.diff
Oct 8 2025, 9:56 AM
F18712173: D10447.id.diff
Sep 29 2025, 5:17 AM
F18704701: D10447.id25124.diff
Sep 28 2025, 8:31 AM
F18704700: D10447.id25123.diff
Sep 28 2025, 8:30 AM
F18704699: D10447.id.diff
Sep 28 2025, 8:30 AM
F18683611: D10447.diff
Sep 26 2025, 7:52 AM
Subscribers

Details

Summary

the call to setHeadCommit() was accidentally placed in a if ($background) {} block, which was removed in 54bea94. This adds the removed call.

Test Plan

used --head, worked as expected

Diff Detail

Repository
rARC Arcanist
Branch
fixed_head_arg
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2469
Build 2473: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

talshiri retitled this revision from to restored --head support.
talshiri updated this object.
talshiri edited the test plan for this revision. (Show Details)
talshiri added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2014, 9:02 PM
epriestley updated this revision to Diff 25124.

Closed by commit rARCec35375e96ad (authored by @talshiri, committed by @epriestley).